RFR: 8009723 CMS logs "concurrent mode failure" twice when using (disabling) -XX:-UseCMSCompactAtFullCollection

Erik Helin erik.helin at oracle.com
Mon Mar 11 05:13:53 PDT 2013


Kevin,

On 03/09/2013 12:39 AM, Kevin Walls wrote:
> Hi,
>
> This is a review request for a small change:
>
> http://cr.openjdk.java.net/~kevinw/8009723/webrev/
>
> Using CMS and disabling UseCMSCompactAtFullCollection on the command
> line easily produces a double-logging of the "(concurrent mode failure)"
> message.  This was spotted by Erik Helin.
>
> This is like removing a print statement.

The change looks good, thanks for fixing this!

On 03/09/2013 12:39 AM, Kevin Walls wrote:
> The webrev contains a testcase, but I am currently suggesting I commit
> this without the test as:
>
> 1) it's fairly trivial: remove a print statement, you don't the see
> output of that print statement.
> 2) it requires -XX:-UseCMSCompactAtFullCollection which I don't believe
> is commonly used
> 3) it is a CMS-specific and the current test framework is quite awkward
> to make the test specific (manual work in the java test, or re-exec.  If
> re-execing do we ignore TESTVMOPTS or parse it and add
> UseConcMarkSweepGC?... a few issues there we should solve but this may
> not be the test change that needs that...)
>
> So the test is possible, and useful for verifying it if anybody wants to
> run it right now, but does not seem a necessity and for this small
> change adding to the test harness library to make it more elegant seems
> unnecessary for this minor problem...

I've looked at the tests and I think it looks good. Is there a way, 
besides removing things from TESTVMOPTS,  that you can make sure that 
the test only runs using only the flags you want?

It is fine with me if you want to push the change first and push an 
updated test later.

Thanks,
Erik

> Thanks
> Kevin
>



More information about the hotspot-gc-dev mailing list