RFR (XS): 8007003: ParNew sends the heap summary too early

Bengt Rutisson bengt.rutisson at oracle.com
Mon Mar 11 23:40:45 PDT 2013


Hi Jesper,

Looks good.

I think you can move this line down to after the early exit too:
894 ParNewTracer gc_tracer;
Bengt

11 mar 2013 kl. 18:59 skrev Jesper Wilhelmsson <jesper.wilhelmsson at oracle.com>:

> Hi,
> 
> Looking for a couple of reviews for this small fix.
> 
> If there is a risk for promotion failure then ParNew can decide to do an early exit. In ParNew::collect, the heap summary event is sent before this check, which means that there might be a heap summary without a corresponding garbage collection event.
> 
> The fix is to send the event after the early exit.
> 
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007003
> 
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8007003/webrev/
> 
> Thanks,
> /Jesper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130312/4799e030/attachment.html 


More information about the hotspot-gc-dev mailing list