RFR (XS): 8007003: ParNew sends the heap summary too early

Erik Helin erik.helin at oracle.com
Tue Mar 12 00:31:32 PDT 2013


Hi Jesper,

the change looks good!

I agree with Bengt on moving down the definition of gc_tracer, please 
fix this before pushing (no need for another webrev).

Thanks,
Erik

On 03/11/2013 06:59 PM, Jesper Wilhelmsson wrote:
> Hi,
>
> Looking for a couple of reviews for this small fix.
>
> If there is a risk for promotion failure then ParNew can decide to do an
> early exit. In ParNew::collect, the heap summary event is sent before
> this check, which means that there might be a heap summary without a
> corresponding garbage collection event.
>
> The fix is to send the event after the early exit.
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007003
>
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8007003/webrev/
>
> Thanks,
> /Jesper



More information about the hotspot-gc-dev mailing list