RFR (XXS): 8008684 - CMS: concurrent phase start markers should always be printed

Mikael Gerdin mikael.gerdin at oracle.com
Tue Mar 12 05:45:18 PDT 2013


Thomas,

On 2013-03-07 07:56, Thomas Schatzl wrote:
> Hi,
>
>    new webrev at
>
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8008684/webrev.1/
>
> Passes jprt.

Looks good to me.
It's good that this gets cleaned up.

/Mikael

>
> Note that tty->stamp(bool) automatically adds the colons, so I removed
> them from the string.
>
> Hth,
> Thomas
>
> On Wed, 2013-03-06 at 09:07 -0800, Jon Masamitsu wrote:
>> Thomas,
>>
>> I've added a comment to the bug report to clarify what
>> I think should be changed.  Sorry that my original description
>> was lacking.  Please take a look and let me know if it is
>> still not clear.
>>
>> Jon
>>
>> On 3/6/2013 4:08 AM, Thomas Schatzl wrote:
>>> Hi all,
>>>
>>>     this change always adds a timestamp marker for CMS concurrent phase
>>> messages as suggested by the CR.
>>> I added an extra space between timestamp and the original message for
>>> better readability.
>>>
>>> I.e. instead of printing
>>>
>>> [CMS-concurrent-mark: 0.081/0.081 secs] [Times: user=0.16 sys=0.00,
>>> real=0.09 secs]
>>> [CMS-concurrent-preclean: 0.005/0.005 secs] [Times: user=0.01 sys=0.00,
>>> real=0.00 secs]
>>>
>>> the VM now prints
>>>
>>> 20.014 [CMS-concurrent-mark: 0.081/0.081 secs] [Times: user=0.16
>>> sys=0.00, real=0.09 secs]
>>> 20.019 [CMS-concurrent-preclean: 0.005/0.005 secs] [Times: user=0.01
>>> sys=0.00, real=0.00 secs]
>>>
>>> if -XX:+PrintGCDetails is set with CMS.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~tschatzl/8008684/webrev/
>>>
>>> Bugs
>>> http://bugs.sun.com/view_bug.do?bug_id=8008684
>>>
>>> JIRA:
>>> https://jbs.oracle.com/bugs/browse/JDK-8008684
>>>
>>> Testing:
>>> JPRT
>>>
>>> Thanks,
>>>     Thomas
>>>
>>
>
>


More information about the hotspot-gc-dev mailing list