RFR: 8009763 Add WB test for String.intern()

Leonid Mesnik leonid.mesnik at oracle.com
Wed Mar 13 03:14:58 PDT 2013


Hi

werbrev was updated (thank you for this)
http://cr.openjdk.java.net/~mgerdin/lmesnik/webrev.1/ 
<http://cr.openjdk.java.net/%7Emgerdin/lmesnik/webrev.1/>

JPRT passed with -rtest '*-*-*-runtime/interned'

Leonid
On 03/12/2013 05:05 PM, Mikael Gerdin wrote:
> Hi Leonid,
>
> On 2013-03-12 08:25, Leonid Mesnik wrote:
>> Hi
>> I've added a small test which:
>> 1) creates java string and intern it
>> 2) verify that it presents in StringTable
>> 3) clear reference and call fullGC
>> 4) verify that there is no such string in StringTable
>>
>> Here is webrev:
>> http://cr.openjdk.java.net/~mgerdin/lmesnik/webrev.0/
>
> Overall this looks reasonable.
>
> I have some comments though:
> WB_IsInStringTable is defined to return a jboolean (Ljava/lang/String;)Z
> but the actual function is defined to return an jint. This will 
> probably work but you should fix this to make it consistent.
>
> The function WB_fullGC should have a capital F to be consistent with 
> the naming of the other WB_* functions.
>
>>
>> Tested locally and by JPRT
>>
> did you run jprt with -retest '*-*-*-runtime/interned' as well?
>
> /Mikael


-- 
Leonid Mesnik
JVM SQE



More information about the hotspot-gc-dev mailing list