Request for review: 7196080: assert(max_heap >= InitialHeapSize) in arguments.cpp

Jon Masamitsu jon.masamitsu at oracle.com
Fri Mar 15 09:37:51 PDT 2013


Looks fine.

Jon

On 3/14/2013 5:41 PM, Tao Mao wrote:
> The comment
>
> " 1172 // MaxHeapSize is aligned down in collectorPolicy"
>
> mislead here so I deleted it (because: in fact, in 
> collectorPolicy.cpp, MaxHeapSize is aligned up). But the assertions 
> still have some value.
>
> Please review the new webrev.
> http://cr.openjdk.java.net/~tamao/7196080/webrev.01/
>
> Thanks.
> Tao
>
> On 3/7/13 1:10 PM, Jon Masamitsu wrote:
>> Tao,
>>
>> As per our discussion feel free to delete both
>> assertions.
>>
>> Jon
>>
>> On 03/07/13 08:13, Jon Masamitsu wrote:
>>> Tao,
>>>
>>> The original assertion seems a worthwhile one
>>> (i.e., the maximum heap size is >= to the
>>> initial heap size) to enforce.   The CR says the problem
>>> that not everything has been page aligned.  Is
>>> the latter not true?
>>>
>>> Jon
>>>
>>> On 03/06/13 14:33, Tao Mao wrote:
>>>> 7196080: assert(max_heap >= InitialHeapSize) in arguments.cpp
>>>> https://jbs.oracle.com/bugs/browse/JDK-7196080
>>>>
>>>> webrev:
>>>> http://cr.openjdk.java.net/~tamao/7196080/webrev.00/
>>>>
>>>> changeset:
>>>> 1. inequality doesn't transfer here.
>>>> X >= align_down(X)
>>>> X >= I
>>>> altogether, cannot infer that align_down(X) >= I. Simple math!
>>>> So, I have removed the original assertion "max_heap >= 
>>>> InitialHeapSize".
>>>> 2. It's reasonable to check an extra assertion "max_heap > = 
>>>> OldSize", following the comment above the assertions.
>



More information about the hotspot-gc-dev mailing list