RFR: 8008917 CMS: Concurrent mode failure tracing event

Bengt Rutisson bengt.rutisson at oracle.com
Tue Mar 19 02:51:03 PDT 2013


Hi Kevin,

Me and Erik looked at this and we think it looks good.

One minor thing would be to wrap the lines inside "if (first_state > 
Idling) {" in a separate method to make it more readable.

Thanks,
Bengt and Erik

On 3/12/13 6:49 PM, Jesper Wilhelmsson wrote:
> Looks good!
> Ship it!
> /Jesper
>
>
> On 12/3/13 4:58 PM, Kevin Walls wrote:
>> Hi,
>>
>> This is the updated hsx24 webrev with a more generic name:
>>
>> http://cr.openjdk.java.net/~kevinw/8008917/hsx24.01/webrev/
>>
>> it builds upon the change for 8009723, so a second failure message is 
>> removed
>> when compared to the parent, as that change isn't in hsx24 yet (only 
>> latest, so
>> a backport of that is required before pushing this).
>>
>> Thanks
>> Kevin
>>
>>
>> Jesper Wilhelmsson wrote:
>>> Looks good!
>>>
>>> Since we want to implement this event for G1 as well, maybe we 
>>> should remove
>>> the "CMS" from the event name and path?
>>>
>>> Thanks,
>>> /Jesper
>>>
>>> On 1/3/13 6:34 PM, Kevin Walls wrote:
>>>> Hi,
>>>>
>>>> I'd like some reviews on this CMS Concurrent Mode Failure event:
>>>>
>>>> http://cr.openjdk.java.net/~kevinw/8008917/hotspot/
>>>>
>>>> The event doesn't actually carry any new information, but it is a 
>>>> warning we
>>>> need to capture.
>>>>
>>>> This is against hsx24, I'll prepare the same, or reviewed, changes 
>>>> against very
>>>> latest hotspot also.
>>>>
>>>> Thanks
>>>> Kevin
>>>>
>>



More information about the hotspot-gc-dev mailing list