RFR (XXS): 8010289: PSParallelCompact::marking_phase should use instance GCTracer

Erik Helin erik.helin at oracle.com
Wed Mar 20 06:10:19 PDT 2013


Thanks!

On 03/19/2013 04:20 PM, Mikael Gerdin wrote:
> Erik,
>
> On 2013-03-19 15:26, Erik Helin wrote:
>> Mikael,
>>
>> On 03/19/2013 02:54 PM, Mikael Gerdin wrote:
>>> Erik,
>>>
>>> On 2013-03-19 14:20, Erik Helin wrote:
>>>> Hi all,
>>>>
>>>> the method PSParallelCompact::marking_phase takes a GCTracer* as
>>>> argument. This is not needed since what is passed is just the
>>>> address of
>>>> the instance GCTracer, marking_phase can just use the instance GCTracer
>>>> directly instead.
>>>>
>>>> This change removes the argument and uses the instance GCTracer
>>>> instead.
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~ehelin/8010289/webrev.00/
>>>
>>> I don't see any change to the caller of PSParallelCompact::marking_phase
>>> in your webrev, am I missing something?
>>
>> No you are not, I am clearly missing something :)
>>
>> Please see new webrev at:
>> http://cr.openjdk.java.net/~ehelin/8010289/webrev.01/
>
> Looks good, ship it!
> /m
>
>>
>> Thanks,
>> Erik
>>
>>> /Mikael
>>>
>>>>
>>>> Bug:
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010289
>>>>
>>>> Thanks,
>>>> Erik
>>



More information about the hotspot-gc-dev mailing list