RFR (S): 8010294: Refactor HeapInspection to make it more reusable

Erik Helin erik.helin at oracle.com
Fri Mar 22 02:06:00 PDT 2013


Hi all,

I have refactored the HeapInspection class to prepare for the 
vm/gc/detailed/object_count_after_gc event.

The refactoring mainly consists of breaking up the rather long 
heap_inspect function to multiple small functions that can be reused.

I also moved the public enums used to initialize KlassInfoTable and 
KlassInfoHisto to private constants. Now they no longer have to be 
passed as an argument to the constructor.

I also added a test to ensure that my refactoring did not break anything 
(the test is not that extensive but at least it ensures that the basic 
stuff is working).

Webrev:
http://cr.openjdk.java.net/~ehelin/8010294/webrev.00/

Bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010294

Testing:
- JPRT
- A new jtreg test (see webrev)

Thanks,
Erik


More information about the hotspot-gc-dev mailing list