Request for review: 8010518 Move deprecating CMSIncrementalMode from Arguments::check_deprecated_gcs() to Arguments::check_deprecated_gc_flags()

Tao Mao tao.mao at oracle.com
Fri Mar 22 20:50:54 PDT 2013


Thank you for review and suggestion, Bengt. The Jira is updated.
Tao

On 3/21/13 9:18 PM, Bengt Rutisson wrote:
>
> Hi Tao,
>
> The change looks good.
>
> The bug report is a little sparse on information - it basically just 
> contains the title. I think it could be worth adding a line about why 
> we want to do this and maybe also comment on why you update the 
> message for MaxGCMinorPauseMillis.
>
> Something like:
>
> "When Arguments::check_deprecated_gcs() was added the check for the 
> use of the deprecated flag CMSIncrementalMode was included there. 
> Later the Arguments::check_deprecated_gc_flags() method was added. 
> Since the CMSIncrementalMode is just a flag it seems more logical to 
> check it in Arguments::check_deprecated_gc_flags() than in 
> Arguments::check_deprecated_gcs()."
>
> You can probably come up with a short comment on the 
> MaxGCMinorPauseMillis message update. This was not suggested by me, so 
> I'll let you figure something out ;)
>
> Bengt
>
> On 3/22/13 12:23 AM, Tao Mao wrote:
>> A simple changeset. Need a reviewer!
>>
>> 8010518 Move deprecating CMSIncrementalMode from 
>> Arguments::check_deprecated_gcs() to 
>> Arguments::check_deprecated_gc_flags()
>> https://jbs.oracle.com/bugs/browse/JDK-8010518
>>
>> webrev:
>> http://cr.openjdk.java.net/~tamao/8010518/webrev.00/
>>
>> changeset:
>> Cleanup suggested by Bengt.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130322/690da3a6/attachment-0001.html 


More information about the hotspot-gc-dev mailing list