Request for review: 8010518 Move deprecating CMSIncrementalMode from Arguments::check_deprecated_gcs() to Arguments::check_deprecated_gc_flags()

Bengt Rutisson bengt.rutisson at oracle.com
Sun Mar 24 13:16:22 PDT 2013


Hi Tao,

On 3/23/13 4:51 AM, Tao Mao wrote:
> Thank you for review and suggestion. A new webrev is updated.
> http://cr.openjdk.java.net/~tamao/8010518/webrev.01/

I like Jon's suggestion about removing the word "likely" but that means 
that you need to update these tests:

test/gc/startup_warnings/TestCMSIncrementalMode.java
test/gc/startup_warnings/TestIncGC.java

Also, would it make sense to remove the word "likely" from the warning 
messages in Arguments::check_deprecated_gcs() too? In that case you need 
to update these tests as well:

test/gc/startup_warnings/TestDefNewCMS.java
test/gc/startup_warnings/TestParNewSerialOld.java

Bengt

>
> Tao
>
> On 3/22/13 1:56 PM, Jon Masamitsu wrote:
>> Tao,
>>
>> Changes look fine.  I would remove the "likely" so that messages read 
>> like
>>
>> "and will be removed in a future release"
>>
>> Fewer words are better and the intent is still clear.
>>
>> Jon
>>
>>
>> On 3/21/2013 4:23 PM, Tao Mao wrote:
>>> A simple changeset. Need a reviewer!
>>>
>>> 8010518 Move deprecating CMSIncrementalMode from 
>>> Arguments::check_deprecated_gcs() to 
>>> Arguments::check_deprecated_gc_flags()
>>> https://jbs.oracle.com/bugs/browse/JDK-8010518
>>>
>>> webrev:
>>> http://cr.openjdk.java.net/~tamao/8010518/webrev.00/
>>>
>>> changeset:
>>> Cleanup suggested by Bengt.
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130324/34b1f9e3/attachment.html 


More information about the hotspot-gc-dev mailing list