RFR (M): 8008920: Tracing events for heap statistics

Erik Helin erik.helin at oracle.com
Mon Mar 25 04:33:15 PDT 2013


Bengt,

On 03/25/2013 12:28 PM, Bengt Rutisson wrote:
>
> Hi Erik,
>
> This looks good.
>
> One small nit. In VM_GC_HeapInspection::collect() you preserved the
> comment from VM_GC_HeapInspection::doit(). The comment talks about
> issuing a warning message, but the code to log that message is left in
> doit(). Could we update the comment to be more consistent with the new
> code?

I will update the comment.

Thanks,
Erik

> Thanks,
> Bengt
>
> On 3/22/13 9:55 AM, Erik Helin wrote:
>> All,
>>
>> based on internal feedback, this change has been updated.
>>
>> The event has been renamed to vm/gc/detailed/object_count_after_gc.
>> Furthermore, the part of the change that updated
>> heapInspection.cpp/hpp has been extracted to a separate change (also
>> out for review on hotspot-gc-dev at openjdk.java.net).
>>
>> New webrev located at:
>> http://cr.openjdk.java.net/~ehelin/8008920/webrev.01/
>>
>> Thanks,
>> Erik
>>
>> On 03/16/2013 11:38 AM, Erik Helin wrote:
>>> Hi all,
>>>
>>> this change adds an event, vm/gc/detailed/class_count_after_gc, that
>>> sends information about the number of instances of each class on the
>>> heap (as well as size and the name of the class).
>>>
>>> The event is sent after the marking phase for all old collections and an
>>> object will be counted as live if the GC think that the object is live
>>> (this is only tricky in the case of a concurrent collection).
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ehelin/8008920/webrev.00/
>>>
>>> Bug:
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008920
>>>
>>> Testing:
>>> JPRT
>>>
>>> Thanks,
>>> Erik
>>
>



More information about the hotspot-gc-dev mailing list