Request for review: 8010518 Move deprecating CMSIncrementalMode from Arguments::check_deprecated_gcs() to Arguments::check_deprecated_gc_flags()

Jon Masamitsu jon.masamitsu at oracle.com
Mon Mar 25 07:03:42 PDT 2013


Thanks for the change.  Looks good.

Jon


On 3/22/13 8:51 PM, Tao Mao wrote:
> Thank you for review and suggestion. A new webrev is updated.
> http://cr.openjdk.java.net/~tamao/8010518/webrev.01/
>
> Tao
>
> On 3/22/13 1:56 PM, Jon Masamitsu wrote:
>> Tao,
>>
>> Changes look fine.  I would remove the "likely" so that messages read 
>> like
>>
>> "and will be removed in a future release"
>>
>> Fewer words are better and the intent is still clear.
>>
>> Jon
>>
>>
>> On 3/21/2013 4:23 PM, Tao Mao wrote:
>>> A simple changeset. Need a reviewer!
>>>
>>> 8010518 Move deprecating CMSIncrementalMode from 
>>> Arguments::check_deprecated_gcs() to 
>>> Arguments::check_deprecated_gc_flags()
>>> https://jbs.oracle.com/bugs/browse/JDK-8010518
>>>
>>> webrev:
>>> http://cr.openjdk.java.net/~tamao/8010518/webrev.00/
>>>
>>> changeset:
>>> Cleanup suggested by Bengt.
>>



More information about the hotspot-gc-dev mailing list