RFR: 8009808 TEST-BUG : test case is using bash style tests. Default shell for jtreg is bourne. thus failure

John Cuthbertson john.cuthbertson at oracle.com
Mon Mar 25 10:13:26 PDT 2013


Hi Leonid,

Generally I believe you need two reviewers with at least one "official" 
Reviewer (someone who has Reviewer status for the project you are 
pushing into) but it is OK to push a change with just one review from a 
Reviewer.  It would be better to get another set of eyes - someone from 
the SQE team would be ideal (since this is a regression test), if you 
can. I would wait one more day and, if no one else reviews the test, you 
can go and push.

JohnC

On 3/23/2013 6:48 AM, Leonid Mesnik wrote:
> John
>
> Thank you for review. Is it enough to push fix or I need another one?
>
> Leonid
> On 03/22/2013 10:00 PM, John Cuthbertson wrote:
>> Hi Leonid,
>>
>> This looks OK to me.
>>
>> JohnC
>>
>> On 3/22/2013 12:06 AM, Leonid Mesnik wrote:
>>> Could anyone please review this small test fix.
>>>
>>> Leonid
>>> On 03/20/2013 04:16 PM, Leonid Mesnik wrote:
>>>> Hi
>>>>
>>>> Could you please review fix for  8009808 TEST-BUG : test case is 
>>>> using bash style tests. Default shell for jtreg is bourne. thus 
>>>> failure.
>>>>
>>>> I've completely rewritten test in java without major changes it 
>>>> test logic.
>>>> I remove CMS so test could be run when CMS is not supported. Also I 
>>>> changed max memory to 128M to reduce memory load and increase 
>>>> number of GC log entries.
>>>>
>>>> Here is the link:
>>>> http://cr.openjdk.java.net/~mgerdin/lmesnik/log_rot_test/webrev.0/ 
>>>> <http://cr.openjdk.java.net/%7Emgerdin/lmesnik/log_rot_test/webrev.0/>
>>>>
>>>
>>>
>>
>
>



More information about the hotspot-gc-dev mailing list