Request for review: 8010518 Move deprecating CMSIncrementalMode from Arguments::check_deprecated_gcs() to Arguments::check_deprecated_gc_flags()
tao.mao at oracle.com
Mon Mar 25 11:48:55 PDT 2013
Thank you for pointing it out, Bengt. A new webrev is updated.
Please see inline.
On 3/24/13 1:16 PM, Bengt Rutisson wrote:
> Hi Tao,
> On 3/23/13 4:51 AM, Tao Mao wrote:
>> Thank you for review and suggestion. A new webrev is updated.
> I like Jon's suggestion about removing the word "likely" but that
> means that you need to update these tests:
Test files modified.
> Also, would it make sense to remove the word "likely" from the warning
> messages in Arguments::check_deprecated_gcs() too? In that case you
> need to update these tests as well:
Have we made a decision to certainly remove these gc comb's in future?
If so, it's OK to state so. Anyway, it would be better to resolve it
with a separate CR.
>> On 3/22/13 1:56 PM, Jon Masamitsu wrote:
>>> Changes look fine. I would remove the "likely" so that messages
>>> read like
>>> "and will be removed in a future release"
>>> Fewer words are better and the intent is still clear.
>>> On 3/21/2013 4:23 PM, Tao Mao wrote:
>>>> A simple changeset. Need a reviewer!
>>>> 8010518 Move deprecating CMSIncrementalMode from
>>>> Arguments::check_deprecated_gcs() to
>>>> Cleanup suggested by Bengt.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-gc-dev