Request for review: 8010518 Move deprecating CMSIncrementalMode from Arguments::check_deprecated_gcs() to Arguments::check_deprecated_gc_flags()

Bengt Rutisson bengt.rutisson at oracle.com
Mon Mar 25 21:56:55 PDT 2013


Hi Tao,

Thanks for updating the tests. Looks good to me.

Have you tried running the tests? It is a very small change so it should 
be ok. But our testing process is very strange and it may be that these 
tests are not run until PIT testing, so running them once before pushing 
is a good idea to avoid unnecessary issues later on.

Also, I see that you decided not to remove "likely" from the other 
messages in Arguments::check_deprecated_gcs(). Would you like to do that 
as a separate change or do you think we should leave those messages 
unchanged?

Thanks,
Bengt

On 3/25/13 7:48 PM, Tao Mao wrote:
> Thank you for pointing it out, Bengt. A new webrev is updated.
> http://cr.openjdk.java.net/~tamao/8010518/webrev.02/
>
> Please see inline.
> Tao
>
> On 3/24/13 1:16 PM, Bengt Rutisson wrote:
>>
>> Hi Tao,
>>
>> On 3/23/13 4:51 AM, Tao Mao wrote:
>>> Thank you for review and suggestion. A new webrev is updated.
>>> http://cr.openjdk.java.net/~tamao/8010518/webrev.01/
>>
>> I like Jon's suggestion about removing the word "likely" but that 
>> means that you need to update these tests:
>>
>> test/gc/startup_warnings/TestCMSIncrementalMode.java
>> test/gc/startup_warnings/TestIncGC.java
> Test files modified.
>>
>> Also, would it make sense to remove the word "likely" from the 
>> warning messages in Arguments::check_deprecated_gcs() too? In that 
>> case you need to update these tests as well:
>>
>> test/gc/startup_warnings/TestDefNewCMS.java
>> test/gc/startup_warnings/TestParNewSerialOld.java
> Have we made a decision to certainly remove these gc comb's in future? 
> If so, it's OK to state so. Anyway, it would be better to resolve it 
> with a separate CR.
>>
>> Bengt
>>
>>>
>>> Tao
>>>
>>> On 3/22/13 1:56 PM, Jon Masamitsu wrote:
>>>> Tao,
>>>>
>>>> Changes look fine.  I would remove the "likely" so that messages 
>>>> read like
>>>>
>>>> "and will be removed in a future release"
>>>>
>>>> Fewer words are better and the intent is still clear.
>>>>
>>>> Jon
>>>>
>>>>
>>>> On 3/21/2013 4:23 PM, Tao Mao wrote:
>>>>> A simple changeset. Need a reviewer!
>>>>>
>>>>> 8010518 Move deprecating CMSIncrementalMode from 
>>>>> Arguments::check_deprecated_gcs() to 
>>>>> Arguments::check_deprecated_gc_flags()
>>>>> https://jbs.oracle.com/bugs/browse/JDK-8010518
>>>>>
>>>>> webrev:
>>>>> http://cr.openjdk.java.net/~tamao/8010518/webrev.00/
>>>>>
>>>>> changeset:
>>>>> Cleanup suggested by Bengt.
>>>>
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130326/30cbcdca/attachment-0001.html 


More information about the hotspot-gc-dev mailing list