RFR (S): 8010818: NPG: Remove metaspace memory pools

Mikael Gerdin mikael.gerdin at oracle.com
Tue Mar 26 08:28:34 PDT 2013


Erik,

On 2013-03-26 16:03, Erik Helin wrote:
> Hi all,
>
> I pushed "8000754: NPG: Implement a MemoryPool MXBean for Metaspace"
> last Friday (April 22). Unfortunately, the change triggered a couple of
> bugs:
>
> - http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010719
>    8010719 : NPG: The metaspace memory pools acquires Metaspace
>              allocation lock out of order with Service_lock
> - http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010734
>    8010734 : NPG: The test MemoryTest.java needs to be updated to
>              support metaspace
> - http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010730
>    8010730 : NPG: Bad assert in JVM_ENTRY(jobject,
>              jmm_GetMemoryUsage(JNIEnv* env, jboolean heap))
>
> In order to not cause disturbance upstream (in hotspot-main), it is
> better to revert the change 8000754, since these bugs are only triggered
> due to the metaspace memory pools.
>
> The reverse patch was created by running:
>
>    hg diff -r 4321 -r 4322 --reverse
>
> in the hotspot-gc/hotspot repistory.
>
> Webrev:
> http://cr.openjdk.java.net/~ehelin/8010818/webrev.00/

Looks good to me.
/m

>
> Bug:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010818
>
> Testing:
> - All tests that failed during nightly testing are now passing
> - JPRT
>
> Thanks,
> Erik


More information about the hotspot-gc-dev mailing list