RFR: 8024671: G1 generates assert error messages in product builds

Aleksey Shipilev aleksey.shipilev at oracle.com
Thu Sep 12 05:29:50 PDT 2013


Thanks Bengt!
I need a sponsor to push this.

-Aleksey.

On 09/12/2013 04:15 PM, Bengt Rutisson wrote:
> 
> Hi Aleksey,
> 
> Nice catch! Thanks for finding and fixing this!
> 
> Looks good.
> 
> Bengt
> 
> 
> On 9/12/13 1:59 PM, Aleksey Shipilev wrote:
>> Hi,
>>
>> Please review and push this simple change:
>>    http://cr.openjdk.java.net/~shade/8024671/webrev.00/
>>
>> TL;DR: err_msg() is not getting erased in product builds, because
>> check_card_num is not a macro, causing the performance regression. Turns
>> out it is simpler to inline the check_card_num all along, because it is
>> more consistent to other asserts.
>>
>> Testing:
>>    (the change is trivial, so the testing is limited)
>>    - built on Linux x86_64/{release,fastdebug}
>>    - run the targeted microbenchmark Linux x86_64/{release,fastdebug}
>>
>> Thanks,
>> -Aleksey.
> 



More information about the hotspot-gc-dev mailing list