Review request: 8024751: Fix bugs in TraceMetadata

Stefan Karlsson stefan.karlsson at oracle.com
Thu Sep 12 23:57:54 PDT 2013


On 09/13/2013 08:22 AM, Bengt Rutisson wrote:
>
> Hi Stefan,
>
> On 9/12/13 10:00 PM, Stefan Karlsson wrote:
>> http://cr.openjdk.java.net/~stefank/8024751/webrev.00/
>>
>> Small fixes two fix some issues when TraceMetadata* flags are turned on.
>>
>> - TraceMetadataHumongousAllocation crashes.
>> - TraceMetadataChunkAllocation prints the same block_freelist() 
>> multiple times.
>
> Looks good. I'm fine with pushing this as is, but I think I would have 
> preferred that this code:
>
>
> 2369   if (next != NULL) {
> 2370     if (TraceMetadataHumongousAllocation &&
> 2371         SpaceManager::is_humongous(next->word_size())) {
> 2372       gclog_or_tty->print_cr("  new humongous chunk word size " 
> PTR_FORMAT,
> 2373                              next->word_size());
> 2374     }
> 2375   }
>
> was more like:
>
> 2370     if (TraceMetadataHumongousAllocation &&
> 2371         next != NULL && 
> SpaceManager::is_humongous(next->word_size())) {
> 2372       gclog_or_tty->print_cr("  new humongous chunk word size " 
> PTR_FORMAT,
> 2373                              next->word_size());
> 2374     }
>
> To me it makes it clearer that this is only a tracing section.

Fair enough. I'll change it.

thanks,
StefanK
>
> Thanks,
> Bengt
>>
>> thanks,
>> StefanK
>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130913/43974c1a/attachment-0001.html 


More information about the hotspot-gc-dev mailing list