RFR (S): 8024662: gc/arguments/TestUseCompressedOopsErgo.java does not compile

Thomas Schatzl thomas.schatzl at oracle.com
Tue Sep 17 05:38:36 PDT 2013


Hi,

  can I have reviews for the following small change? It fixes
compilation and running of the above JTREG test.

The compilation issue has been slipped through my testing, and the
problem at execution is actually caused by another change pushed just
before this one that changed the name of the "ClassMetaspaceSize" global
to "MetaspaceSize".

I also started to refactor just a little, i.e. replace one manual check
for equality by calls to the Asserts class that has been introduced in
another CR at around the same time I think.

More refactoring will be done in JDK-8024925, an issue I found while
improving the tests for this change (and JDK-8024669). Fixing
JDK-8024925 seems to be out of scope here.

Please consider reviewing in conjunction with the RFR for JDK-8024669
which I will send too.

bugs.openjdk.com
https://bugs.openjdk.java.net/browse/JDK-8024662

webrev:
http://cr.openjdk.java.net/~tschatzl/8024662/

testing:
jprt, manual jtreg execution, jprt jtreg testing

Thanks,
  Thomas



More information about the hotspot-gc-dev mailing list