RFR (M) : 8024319 : Add regression tests on documented GC-related -XX:+Print* options

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Tue Sep 17 14:16:04 PDT 2013


Looks good!
I ran the tests and they passed. I introduced a bug in the verbose logging and 
the relevant test failed. Awesome!

/Jesper

Filipp Zhinkin skrev 17/9/13 6:14 PM:
> I'll be very appreciated if someone will take a look at it.
>
> Thanks,
> Filipp.
>
> On 09/10/2013 01:15 PM, Filipp Zhinkin wrote:
>> Hi,
>>
>> I'd like to get a review on new regression tests on various GC-related
>> -XX:+Print* options:
>>
>> http://bugs.sun.com/view_bug.do?bug_id=8024319
>>
>> webrev:
>> http://cr.openjdk.java.net/~kshefov/8024319/webrev.00/
>>
>> Brief overview of tests to be added:
>> Following tests verify that PrintGC and PrintGCDetails flags work and emit
>> appropriate output.
>> Tests grouped by GC in order to handle different GC logging format.
>> gc/arguments/print/TestCMSPrintGCFlags
>> gc/arguments/print/TestG1PrintGCFlags.java
>> gc/arguments/print/TestSerialAndParallelPrintGCFlags
>>
>> Test on PrintGCTimeStamps and PrintGCDateStamps flags. It verifies that
>> options and their
>> combinations emit appropriate output and verifies that time and date stamps
>> are not decreasing over time.
>> gc/arguments/print/TestGCStampFlags
>>
>> Test on PrintGCApplicationConcurrentTime and PrintGCApplicationStoppedTime.
>> It verifies that these options emit appropriate output.
>> gc/arguments/print/TestPrintGCAppTimeFlags
>>
>> Test on PrintGCTaskTimeStamps flah. It verifies that when this option emit
>> output only with parallel GC
>> and also verifies that all timestamps are not decreasing and for each GC
>> thread verifies that number of
>> reported task timestamps equal to expected number of tasks.
>> gc/arguments/print/TestPrintGCTaskTimeStampsFlag
>>
>> Test on PrintTenuringDistribution flag. It verifies that appropriate output is
>> emitted when this option is
>> turned on and also verifies that reported values lies between 0 and selected
>> MaxTenuringThreshold.
>> gc/arguments/print/TestPrintTenuringDistributionFlag*
>>
>> *Testing done: manual testing and JPRT.
>>
>> Thanks,
>> Filipp.
>>
>>
>


More information about the hotspot-gc-dev mailing list