hg: hsx/hotspot-gc/hotspot: 8024974: Incorrect use of GC_locker::is_active()

stefan.karlsson at oracle.com stefan.karlsson at oracle.com
Fri Sep 20 08:38:34 PDT 2013


Changeset: 2c022e432e10
Author:    stefank
Date:      2013-09-20 10:53 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/2c022e432e10

8024974: Incorrect use of GC_locker::is_active()
Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint.
Reviewed-by: brutisso, dcubed
Contributed-by: per.liden at oracle.com

! src/share/vm/classfile/symbolTable.cpp
! src/share/vm/memory/gcLocker.cpp
! src/share/vm/memory/gcLocker.hpp



More information about the hotspot-gc-dev mailing list