RFR(XS): JDK-8023643 - G1: assert failed when NewSize was specified greater than MaxNewSize

Bengt Rutisson bengt.rutisson at oracle.com
Tue Sep 24 04:44:11 PDT 2013


Hi Jesper,

On 9/24/13 11:31 AM, Jesper Wilhelmsson wrote:
> Hi,
>
> Can I have a review of this minor fix.
>
> Since I was messing with that code anyway I fixed JDK-8023643 [1].
>
> G1 didn't handle if the user sets incompatible NewSize and MaxNewSize. 
> All other collectors exits with an error in this case, so I added the 
> same check to the G1 code path.

The other collectors don't handle this case yet. They will do that when 
the fix that is out for review as "RFR: JDK-8016309 - assert(eden_size > 
0 && survivor_size > 0) failed" has been pushed.

> Webrev: http://cr.openjdk.java.net/~jwilhelm/8023643/webrev/

For G1 this looks reasonable.

Thanks,
Bengt

>
> [1] https://bugs.openjdk.java.net/browse/JDK-8023643
>
> Thanks!
> /Jesper



More information about the hotspot-gc-dev mailing list