RFR(XS): JDK-8023643 - G1: assert failed when NewSize was specified greater than MaxNewSize

Thomas Schatzl thomas.schatzl at oracle.com
Tue Sep 24 07:32:29 PDT 2013


Hi,

On Tue, 2013-09-24 at 17:23 +0400, Filipp Zhinkin wrote:
> Hi,
> 
> On 09/24/2013 04:29 PM, Thomas Schatzl wrote:
> > Hi,
> >
> > On Tue, 2013-09-24 at 11:31 +0200, Jesper Wilhelmsson wrote:
> >> Hi,
> >>
> >> Can I have a review of this minor fix.
> >>
> >> Since I was messing with that code anyway I fixed JDK-8023643 [1].
> >>
> >> G1 didn't handle if the user sets incompatible NewSize and MaxNewSize. All other
> >> collectors exits with an error in this case, so I added the same check to the G1
> >> code path.
> >>
> >> Webrev: http://cr.openjdk.java.net/~jwilhelm/8023643/webrev/
> >>
> >> [1] https://bugs.openjdk.java.net/browse/JDK-8023643
> > Looks okay. Could you add a small test case for this issue?
> I'm currently working on tests that will cover that case as well. So 
> additional test may be redundant.
> 

Okay, then the change is fine with me.

Thanks,
Thomas



More information about the hotspot-gc-dev mailing list