RFR (XS): 8024632 - Description of InitialSurvivorRatio flag in globals.hpp is incorrect

Tao Mao tao.mao at oracle.com
Tue Sep 24 10:09:18 PDT 2013


Hi Per,

Currently we have

3029   product(uintx, NewRatio, 2,                                               \
3030           "Ratio of new/old generation sizes")                              \


it should be

3029   product(uintx, NewRatio, 2,                                               \
3030           "Ratio of*old/new*  generation sizes")                              \


Thanks.
Tao


On 9/24/13 3:05 AM, Per Liden wrote:
> Hi Tao,
>
> Thanks for reviewing.
>
> NewRatio looks ok, are you maybe referring to SurvivorRatio?
>
> /Per
>
> On 2013-09-23 20:41, Tao Mao wrote:
>> Hi Per,
>>
>> Looks good to me.
>>
>> Please also note that the wording of NewRatio's definition has the 
>> same problem. If interested, please create a new CR and fix it.
>>
>> Thanks.
>> Tao
>>
>> On 9/23/13 5:18 AM, Per Liden wrote:
>>> Hi,
>>>
>>> http://cr.openjdk.java.net/~pliden/8024632/webrev.01/
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8024632
>>>
>>> Summary: Fix for the incorrect description of InitialSurvivorRatio. 
>>> The ratio should be described as "young gen / survivor size", not 
>>> "eden size / survivor size".
>>>
>>> cheers,
>>> /Per
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130924/6898df94/attachment.html 


More information about the hotspot-gc-dev mailing list