RFR (XS): 8024632 - Description of InitialSurvivorRatio flag in globals.hpp is incorrect

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Tue Sep 24 10:13:55 PDT 2013


Tao,

Didn't you have a patch that fixed a ton of these errors in globals.hpp? What 
happened to that one?
/Jesper


Tao Mao skrev 24/9/13 7:09 PM:
> Hi Per,
>
> Currently we have
>
> 3029   product(uintx, NewRatio, 2,                                               \
> 3030           "Ratio of new/old generation sizes")                              \
>
>
> it should be
>
> 3029   product(uintx, NewRatio, 2,                                               \
> 3030           "Ratio of*old/new*  generation sizes")                              \
>
>
> Thanks.
> Tao
>
>
> On 9/24/13 3:05 AM, Per Liden wrote:
>> Hi Tao,
>>
>> Thanks for reviewing.
>>
>> NewRatio looks ok, are you maybe referring to SurvivorRatio?
>>
>> /Per
>>
>> On 2013-09-23 20:41, Tao Mao wrote:
>>> Hi Per,
>>>
>>> Looks good to me.
>>>
>>> Please also note that the wording of NewRatio's definition has the same
>>> problem. If interested, please create a new CR and fix it.
>>>
>>> Thanks.
>>> Tao
>>>
>>> On 9/23/13 5:18 AM, Per Liden wrote:
>>>> Hi,
>>>>
>>>> http://cr.openjdk.java.net/~pliden/8024632/webrev.01/
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8024632
>>>>
>>>> Summary: Fix for the incorrect description of InitialSurvivorRatio. The
>>>> ratio should be described as "young gen / survivor size", not "eden size /
>>>> survivor size".
>>>>
>>>> cheers,
>>>> /Per
>>


More information about the hotspot-gc-dev mailing list