Request for review: 8016302: Change type of the number of GC workers to unsigned int (2)

Vladimir Kempik vladimir.kempik at oracle.com
Wed Sep 25 03:47:30 PDT 2013


Hello

Thanks for comments, updated webrev - 
http://cr.openjdk.java.net/~vkempik/8016302/webrev.02/


On 24.09.2013 17:22, Thomas Schatzl wrote:
> Hi,
>
> On Thu, 2013-09-19 at 16:22 +0200, Vladimir Kempik wrote:
>> Hello
>>
>> Thanks for comments, here is updated webrev -
>> http://cr.openjdk.java.net/~vkempik/8016302/webrev.01/
>>
> - the comments in DirtyCardQueueSet::mut_process_buffer() should be
> adapted that we use uints now. They talk of worker_i of -1.
>
> E.g.
>
> 130  // If worker_i is not -1 then the thread has already claimed
> 131  // a par_id. We make note of it using the already_claimed value
>
> - in G1GCPhaseTimes::print_stats() we need to use UINT32_FORMAT instead
> of %d as the printf() specifier for uints.
>
> - same in ScanRSClosure::printCard().
>
> Thanks,
>    Thomas
>



More information about the hotspot-gc-dev mailing list