RFR (XS): 8024632 - Description of InitialSurvivorRatio flag in globals.hpp is incorrect

Filipp Zhinkin filipp.zhinkin at oracle.com
Thu Sep 26 04:33:50 PDT 2013


Hi Per,

the way SurvivorRatio is used differs depending on GC.

SurvivorRatio = young space / survivor space size only for G1.

For DefNew and ParNew it is eden / survivor space size.

For Parallel GC it is also eden / survivor space size,
because in that case SurvivorRatio = MinSurvivorRatio - 2 = 
InitialSurvivorRatio - 2.

So SurvivorRatio description is still incorrect.

Thanks,
Filipp.

On 09/24/2013 03:22 PM, Per Liden wrote:
> Updated the webrev to also adjusts the description of SurvivorRatio.
>
> http://cr.openjdk.java.net/~pliden/8024632/webrev.02/
>
> cheers,
> /Per
>
> On 2013-09-24 12:05, Per Liden wrote:
>> Hi Tao,
>>
>> Thanks for reviewing.
>>
>> NewRatio looks ok, are you maybe referring to SurvivorRatio?
>>
>> /Per
>>
>> On 2013-09-23 20:41, Tao Mao wrote:
>>> Hi Per,
>>>
>>> Looks good to me.
>>>
>>> Please also note that the wording of NewRatio's definition has the 
>>> same problem. If interested, please create a new CR and fix it.
>>>
>>> Thanks.
>>> Tao
>>>
>>> On 9/23/13 5:18 AM, Per Liden wrote:
>>>> Hi,
>>>>
>>>> http://cr.openjdk.java.net/~pliden/8024632/webrev.01/
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8024632
>>>>
>>>> Summary: Fix for the incorrect description of InitialSurvivorRatio. 
>>>> The ratio should be described as "young gen / survivor size", not 
>>>> "eden size / survivor size".
>>>>
>>>> cheers,
>>>> /Per
>>
>



More information about the hotspot-gc-dev mailing list