RFR (XS): 8025605: G1: Heap expansion logging misleading for fully expanded heap

Bengt Rutisson bengt.rutisson at oracle.com
Fri Sep 27 12:57:27 PDT 2013


Hi everyone,

Could I have a couple of reviews for this small change?

http://cr.openjdk.java.net/~brutisso/8025605/webrev.00/

Bug:
https://bugs.openjdk.java.net/browse/JDK-8025605

Background:

When running G1 with -XX:+PrintAdaptiveSizePolicy some information about 
the heap sizing is logged. When the heap is fully expanded but the 
ergonomics would have liked to expand even more the following message is 
logged:

[G1Ergonomics (Heap Sizing) did not expand the heap, reason: heap 
expansion operation failed]

It sounds like something failed, but in reality we just hit the -Xmx 
value. We should have a more informative message that does not look like 
a serious failure.

With my suggested patch the message will instead be:

[G1Ergonomics (Heap Sizing) did not expand the heap, reason: heap 
already fully expanded]

Thanks,
Bengt


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130927/432b6462/attachment.html 


More information about the hotspot-gc-dev mailing list