RFR: 8048269: Add flag to turn off class unloading after G1 concurrent mark

Bengt Rutisson bengt.rutisson at oracle.com
Wed Aug 6 08:00:15 UTC 2014


Hi Stefan,

Looks good.

Three minor things:
- g1CollectedHeap.cpp - there is a fixme comment that can be removed
- sharedHeap.cpp - the INCLUDE_ALL_GCS guards are not needed
- we should file a bug to make sure that we don't forget to change CMS 
to use the new flag too

No need for a new webrev for these changes.

Reviewed.
Bengt


On 2014-08-05 10:09, Stefan Karlsson wrote:
>
> On 2014-08-05 09:49, Thomas Schatzl wrote:
>> Hi,
>>
>> On Tue, 2014-08-05 at 09:43 +0200, Bengt Rutisson wrote:
>>> On 2014-08-04 16:07, Stefan Karlsson wrote:
>>>> Hi all,
>>>>
>>>> On 2014-07-18 00:14, Jon Masamitsu wrote:
>> [...]
>>>>> The flag sounds more concise but is it that correct?   With CMS
>>>>> at least (which we hope to make use this same flag) some
>>>>> of the reduction in work would be during marking but the
>>>>> freeing of the metaspace and the cleaning of the system
>>>>> dictionary come later (after the sweep).  I still like
>>>>> ClassUnloadingWithConcurrentMark - not as precise but
>>>>> maybe more correct?
>>>> I'm fine with this flag name.
>>>>
>>>> Does anyone strongly oppose the flag name:
>>>> ClassUnloadingWithConcurrentMark?
>>> No objections from me.
>> Neither from me.
>
> Good.
>
> Here is the updated patch with the new name:
>  http://cr.openjdk.java.net/~stefank/8048269/webrev.01/
>  http://cr.openjdk.java.net/~stefank/8048269/webrev.01.delta/
>
> thanks,
> StefanK
>
>>
>> Thomas
>>
>



More information about the hotspot-gc-dev mailing list