RFR (XXS): 8054362: gc/g1/TestEagerReclaimHumongousRegions2.java timeout

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Mon Aug 18 13:27:33 UTC 2014


> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8054362/webrev.2/

Looks good to me.

Thanks,
Dima



On 18.08.2014 17:09, Thomas Schatzl wrote:
> Hi Dmitry,
>
>    thanks for looking at the change again:
>
> On Mon, 2014-08-18 at 14:14 +0400, Dmitry Fazunenko wrote:
>> Hi Thomas,
>>
> [...]
>>> It would take considerable effort to modify it for multiple region sizes
>>> for no noticable gain.
>> Yes, TestEagerReclaimHumongousRegions2 is the regression test for
>> 8051973 problem.
>> Minimal effort is required to update it to cover more. If you don't mind
>> I can file an RFE for it.
> Yes, let's file an RFE for it.
>
>>>> Could we make the test check the time? Maybe do the loop for 1 minute
>>>> but no more than 20 iterations?
>>> I implemented this idea as it seems less failure prone than trying to
>>> guess the speed of the machine. Fast machine easily finish the test
>>> within the given time, slower ones should get enough coverage.
>> I agree, this approach is better. The fix looks good to me.
>> One minor note: I would reduce timeout from 60 seconds to 50 to finish
>> normally if timeout is set to 1 minute.
>>
> Done.
>
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8054362/webrev.2/
>
> Thanks,
>    Thomas
>



More information about the hotspot-gc-dev mailing list