RFR (XS): 8053998: Hot card cache flush chunk size too coarse grained

Mikael Gerdin mikael.gerdin at oracle.com
Mon Aug 18 14:50:09 UTC 2014


Hi Marcus,

On 2014-08-18 09:27, Marcus Larsson wrote:
> Hi,
>
> Can I have reviews for this small patch changing the hot card cache
> flush chunks to a fixed size?
>
> CR:
> http://cr.openjdk.java.net/~mgerdin/mlarsson/webrev-8053998/

Can you move the value "32" to a constant? Both stringTable.cpp and 
symbolTable.cpp define a
const int ClaimChunkSize = 32;
That seems like a reasonable pattern, but you should probably make it a 
static global or scope it inside G1HotCardCache.

Otherwise it looks good.

For the record I asked Marcus about the value "32" and he had done some 
experiments to come up with the number.

/Mikael

>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8053998
>
> Testing:
> jprt, SPECjbb2013
>
> Thanks,
> Marcus


More information about the hotspot-gc-dev mailing list