RFR (XS): 8055525: Bigapp weblogic+medrec fails to startup after JDK-8038423

Mikael Gerdin mikael.gerdin at oracle.com
Wed Aug 20 12:18:15 UTC 2014


Hi Thomas,

On 2014-08-20 14:08, Thomas Schatzl wrote:
> Hi all,
>
>    some correction to my explanation:

Thanks :)

>
> On Wed, 2014-08-20 at 13:41 +0200, Thomas Schatzl wrote:
>> Hi all,
>>
>>    can I have reviews for the following tiny change that fixes startup on
>> linux with large pages enabled and said large pages configured by the
>> OS?
>>
>> The problem is some unnecessary initialization in G1RegionToSpaceMapper
>> that fakes that all regions are initially committed in that case.
>
> s/G1RegionToSpaceMapper/G1PageBasedVirtualSpace
>
>>
>> This is not required, because the lower layer (G1PageBasedVirtualSpace)
>
> ... because G1PageBasedVirtualSpace already does ...
>
>> already does fake commit/uncommit calls (in that case these calls are
>> nops like done elsewhere).
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8055525
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8055525/webrev/

Looks good.

/Mikael

>>
>> Testing:
>> jprt, manual local testing of bigapps/medrec before/after the change
>
> Thanks,
>    Thomas
>
>


More information about the hotspot-gc-dev mailing list