RFR (XS): 8053998: Hot card cache flush chunk size too coarse grained

Thomas Schatzl thomas.schatzl at oracle.com
Wed Aug 20 13:44:42 UTC 2014


Hi,

On Wed, 2014-08-20 at 15:42 +0200, Marcus Larsson wrote:
> Hello,
> 
> On 08/18/2014 04:50 PM, Mikael Gerdin wrote:
> > Hi Marcus,
> >
> > On 2014-08-18 09:27, Marcus Larsson wrote:
> >> Hi,
> >>
> >> Can I have reviews for this small patch changing the hot card cache
> >> flush chunks to a fixed size?
> >>
> >> CR:
> >> http://cr.openjdk.java.net/~mgerdin/mlarsson/webrev-8053998/
> >
> > Can you move the value "32" to a constant? Both stringTable.cpp and 
> > symbolTable.cpp define a
> > const int ClaimChunkSize = 32;
> > That seems like a reasonable pattern, but you should probably make it 
> > a static global or scope it inside G1HotCardCache.
> 
> Made it a static constant in G1HotCardCache.
> 
> New webrev:
> http://cr.openjdk.java.net/~mgerdin/mlarsson/webrev-8053998v2/


Looks good now, thanks.

Thomas



More information about the hotspot-gc-dev mailing list