RFR (XS): 8055919: Remove dead code in G1 concurrent marking code

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Mon Aug 25 16:00:51 UTC 2014


Hi Thomas,

In CMConcurrentMarkingTask::work() you remove the call to 
_cm->do_yield_check(worker_id). Even though the return value is unused the 
method itself has side effects and I wouldn't necessary call it dead code. Is it 
safe to remove this code?

/Jesper


Thomas Schatzl skrev 25/8/14 17:35:
> Hi all,
>
>    can I have reviews for the following change the removes ~150 LOC of
> dead code from G1's concurrentMark* source files?
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8055919
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8055919/webrev/
> Testing:
> jprt
>
> Thanks,
>    Thomas
>


More information about the hotspot-gc-dev mailing list