RFR (XS): 8055919: Remove dead code in G1 concurrent marking code

Thomas Schatzl thomas.schatzl at oracle.com
Mon Aug 25 16:04:37 UTC 2014


Hi,

On Mon, 2014-08-25 at 18:00 +0200, Jesper Wilhelmsson wrote:
> Hi Thomas,
> 
> In CMConcurrentMarkingTask::work() you remove the call to 
> _cm->do_yield_check(worker_id). Even though the return value is unused the 
> method itself has side effects and I wouldn't necessary call it dead code. Is it 
> safe to remove this code?

No, this is certainly not okay. Thanks for finding this. I will fix
that.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list