RFR (XS): 8055919: Remove dead code in G1 concurrent marking code

Thomas Schatzl thomas.schatzl at oracle.com
Tue Aug 26 07:35:20 UTC 2014


Hi Jesper, Jon,

On Mon, 2014-08-25 at 18:00 +0200, Jesper Wilhelmsson wrote:
> Hi Thomas,
> 
> In CMConcurrentMarkingTask::work() you remove the call to 
> _cm->do_yield_check(worker_id). Even though the return value is unused the 
> method itself has side effects and I wouldn't necessary call it dead code. Is it 
> safe to remove this code?

  here's a diff webrev for the changes:
http://cr.openjdk.java.net/~tschatzl/8055919/webrev.0_to_1/
And the full webrev:
http://cr.openjdk.java.net/~tschatzl/8055919/webrev.1/

I also fixed a few parameter lists in that change. I hope this is not
too much of a bother.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list