RFR (XS): 8055919: Remove dead code in G1 concurrent marking code
jon.masamitsu at oracle.com
Tue Aug 26 17:20:49 UTC 2014
On 08/26/2014 12:35 AM, Thomas Schatzl wrote:
> Hi Jesper, Jon,
> On Mon, 2014-08-25 at 18:00 +0200, Jesper Wilhelmsson wrote:
>> Hi Thomas,
>> In CMConcurrentMarkingTask::work() you remove the call to
>> _cm->do_yield_check(worker_id). Even though the return value is unused the
>> method itself has side effects and I wouldn't necessary call it dead code. Is it
>> safe to remove this code?
> here's a diff webrev for the changes:
Still looks good.
> And the full webrev:
> I also fixed a few parameter lists in that change. I hope this is not
> too much of a bother.
I like your fix of the formatting on the parameter lists. Thanks.
More information about the hotspot-gc-dev