RFR (S): JDK-8055816: Remove dead code in g1BlockOffsetTable

Bengt Rutisson bengt.rutisson at oracle.com
Wed Aug 27 08:53:32 UTC 2014


Thanks Thomas and Mikael for the reviews!

Bengt


On 2014-08-27 10:51, Mikael Gerdin wrote:
> Hi Bengt,
>
> On Tuesday 26 August 2014 12.21.09 Bengt Rutisson wrote:
>> Hi Thomas,
>>
>> Thanks for the review!
>>
>> On 2014-08-26 12:08, Thomas Schatzl wrote:
>>> Hi,
>>>
>>> On Fri, 2014-08-22 at 15:01 +0200, Bengt Rutisson wrote:
>>>> Hi all,
>>>>
>>>> Can I get reviews for this small change to remove dead code from the
>>>> G1BlockOffsetTable implementation?
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~brutisso/8055816/webrev.00/
>>>>
>>>> Bug report:
>>>> https://bugs.openjdk.java.net/browse/JDK-8055816
>>>>
>>>     could you fix the comment for
>>>
>>> G1BlockOffsetArrayContigSpace::zero_bottom_entry_raw? It refers to the
>>> removed method zero_bottom_entry.
>> Fixed:
>>
>> http://cr.openjdk.java.net/~brutisso/8055816/webrev.01/
> Looks good. Nice cleanup.
>
> /Mikael
>
>> Diff compared to last version:
>> http://cr.openjdk.java.net/~brutisso/8055816/webrev.00-01.diff/
>>
>>> Otherwise looks good. Thanks.
>> Great! Thanks!
>>
>> Bengt
>>
>>> Thomas



More information about the hotspot-gc-dev mailing list