RFR: JDK-8055845 - Add trace event for promoted objects

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Wed Aug 27 16:59:59 UTC 2014


Staffan,

Yes, I saw trace.xml. But I think this event not specified there, but 
implemented )
I will appreciate if you copy it in the message, people might review 
that and decide if the event contain all the necessary fields.

And thank you for working on tests!

-- Dima


On 27.08.2014 20:52, Staffan Friberg wrote:
> HI Dima,
>
> The event is specified in trace.xml as all other events, please see 
> the updated webrev as some changes was made to the descriptions.
> http://cr.openjdk.java.net/~brutisso/8055845/webrev.01
>
> I'm in the process of writing regression tests, but they will be a 
> separate webrev as they will be located in a separate repository.
>
> Regards,
> Staffan
>
> On 08/27/2014 04:08 AM, Dmitry Fazunenko wrote:
>> Hi Staffan,
>>
>> Thanks for submitting RFE and implementing it! This event seems to be 
>> used widely.
>> So it's very important to design it correctly.
>> May I ask you to provide some extra information:
>> - format of event
>>   (this could be included in the CR description)
>> - regression tests for that event will be also required
>> - please include hotspot-dev on CC
>>
>> Thanks,
>> Dima
>>
>> On 25.08.2014 20:28, Staffan Friberg wrote:
>>> Hi,
>>>
>>> Could I please get reviews for this RFE that adds a trace event for 
>>> aging and promotion for young collections in G1, CMS and Parallel GC.
>>> It works similarly to allocation events, and generates the event on 
>>> the slow path when either a direct copy occurs or a new PLAB is 
>>> request.
>>>
>>> Since I'm adding an event I cc:ed the serviceability list in case 
>>> anyone has any comments on the event and changes to trace.xml.
>>>
>>> RFE: https://bugs.openjdk.java.net/browse/JDK-8055845
>>> Webrev: http://cr.openjdk.java.net/~brutisso/8055845/webrev.00
>>>
>>> Bengt has been kind and agreed to both sponsor and host the the webrev.
>>>
>>> Thanks,
>>> Staffan
>>>
>>
>



More information about the hotspot-gc-dev mailing list