RFR (S): 8043243: convert SCAN_AND_FORWARD, SCAN_AND_ADJUST_POINTERS, SCAN_AND_COMPACT macros to methods

Marcus Larsson marcus.larsson at oracle.com
Thu Aug 28 11:46:56 UTC 2014


Hi,

I would like reviews for the following patch converting the SCAN_AND_* 
macros into (inline) methods.

Short summary:
The change is based on the demacroify.patch (bug attachment), using a 
proxy class to enable different functions for obj_size and similar to be 
used for different types of Spaces. Each type of space has a proxy 
defining which methods should be used in the scan_and_* functions.
Made no changes to the actual code in the macros, except for replacing a 
multi-line debug_only(...) with #ifdef ASSERT ... #endif.

Webrev:
http://cr.openjdk.java.net/~brutisso/webrev-8043243/

Bug:
https://bugs.openjdk.java.net/browse/JDK-8043243

Testing:
jprt without problems
SPECjbb2013, SPECjbb2005, SPECjvm2008 - no significant changes

Thanks,
Marcus


More information about the hotspot-gc-dev mailing list