RFR (XS): 8054808: Bitmap verification sometimes fails after Full GC aborts concurrent mark

Jon Masamitsu jon.masamitsu at oracle.com
Thu Aug 28 14:55:19 UTC 2014


On 08/28/2014 01:34 AM, Thomas Schatzl wrote:
> Hi Bengt and Jon,
>
>    thanks for the reviews :)
>
> On Thu, 2014-08-28 at 10:02 +0200, Bengt Rutisson wrote:
>> Hi Thomas,
>>
>> (Had an offline discussion with Thomas about this. Replying here for the
>> record.)
>>
>> The proposed fix works fine but there is a slightly simpler solution.
>> For all HeapRegions we store the original end value in a variable that
>> does not change. We could use that for this fix instead of having to
>> calculate the end value.
>>
>> Something like:
>>
>> HeapWord* end = r->orig_end();
>> return _bitmap->getNextMarkedWordAddress(r->bottom(), end) != end;
>>
> New webrev implementing this at
> http://cr.openjdk.java.net/~tschatzl/8054808/webrev.1/

Looks even better.  Reviewed.

Jon

>
> Thanks,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list