RFR (M): JDK-8065993: Merge OneContigSpaceCardGeneration with TenuredGeneration

Mikael Gerdin mikael.gerdin at oracle.com
Mon Dec 1 13:31:57 UTC 2014


Hi Bengt,

On 2014-12-01 13:42, Bengt Rutisson wrote:
>
> Hi everyone,
>
> Could I have a couple of reviews to this cleanup?
>
> http://cr.openjdk.java.net/~brutisso/8065993/webrev.00/

in concurrentMarkSweepGeneration.inline.hpp you've removed the include 
of genCollectedHeap.hpp, is that intentional? There are still references 
to GenCollectedHeap in that file.

in tenuredGeneration.cpp
TenuredGeneration::collect and expand_and_allocate the parameters are 
not properly aligned.

Otherwise the change looks good.
I don't need to re-review the above mentioned changes.

/Mikael

>
> https://bugs.openjdk.java.net/browse/JDK-8065993
>
> During the review of "8064702: Remove the CMS foreground collector"
> Mikael made the comment that we can merge OneContigSpaceCardGeneration
> with TenuredGeneration. This is the change to address that comment.
>
> The motivation to have OneContigSpaceCardGeneration was that the PermGen
> implementation inherited from that class too. When the PermGen was
> removed TenuredGenteration was the only implementation that inherited
> OneContigSpaceCardGeneration.
>
> These classes were exposed in the serviceability agent, so I've made
> changes there too. In the SA the classes are use by for example the
> "jmap -heap" command. Thus, I have been using that command for SA testing.
>
> I also found a couple  of comments that still mentioned PermGen and that
> now also mentioned the removed OneContigSpaceCardGeneration. Rather than
> updating/re-writing these comments I removed them. They did not add much
> to the understanding of the code anymore in my opinion.
>
> Note that I renamed generation.inline.hpp to tenuredGeneration.inline
> since it only contained inline fuctions for OneContigSpaceCardGeneration
> which now belongs to TenuredGeneration.
>
> Thanks,
> Bengt


More information about the hotspot-gc-dev mailing list