RFR (S): 8066102: Clean up HeapRegionRemSet files
kim.barrett at oracle.com
Mon Dec 1 21:36:47 UTC 2014
On Dec 1, 2014, at 7:07 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>> This change surprised me though:
>> 978 _bosa(hrrs->bosa()),
>> 943 _bosa(hrrs->_bosa),
>> Violates the Hotspot coding guidelines item about member access from
>> outside the class be through accessor functions. OTOH, the class
>> being accessed has befriended the class doing this access, and the
>> (removed by this changeset) bosa() accessor was private.
> That's the reason why I removed that. I will keep it as is if nobody
I’m OK with that. I see there are other direct member accesses by the friend.
>> Regarding Mikael's comment:
>>> In heapRegionRemSet.hpp:
>>> + // One bits in the bitmaps indicate that the given region or card is live.
>>> typo: "One bit in one of the bitmaps indicate that the.."
>> I think the existing comment is correct, but might be clearer if it
>> "Set bits in the bitmaps ..."
> http://cr.openjdk.java.net/~tschatzl/8066102/webrev.1 (this is a full
> webrev again, really only fixed that comment).
I’m not seeing any change from the original webrev.
More information about the hotspot-gc-dev