RFR (S): 8066102: Clean up HeapRegionRemSet files

Thomas Schatzl thomas.schatzl at oracle.com
Tue Dec 2 08:14:55 UTC 2014


Hi Kim,

On Mon, 2014-12-01 at 16:36 -0500, Kim Barrett wrote:
> On Dec 1, 2014, at 7:07 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> >> Regarding Mikael's comment:
> >>> In heapRegionRemSet.hpp:
> >>> +  // One bits in the bitmaps indicate that the given region or card is live.
> >>> typo: "One bit in one of the bitmaps indicate that the.."
> >> 
> >> I think the existing comment is correct, but might be clearer if it
> >> said
> >> 
> >> "Set bits in the bitmaps ..."
> > 
> > Fixed.
> > 
> > http://cr.openjdk.java.net/~tschatzl/8066102/webrev.1 (this is a full
> > webrev again, really only fixed that comment).
> 
> I’m not seeing any change from the original webrev.

Fixed and reuploaded. Sorry.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list