RFR (S): 8066566: Refactor ParNewGeneration to contain ParNewTracer

Erik Helin erik.helin at oracle.com
Sat Dec 6 09:57:01 UTC 2014


Hi Marcus,

On 2014-12-04 13:05, Marcus Larsson wrote:
> Hi,
>
> I would like reviews for the following small patch.
>
> Like the bug description says, the ParNewTracer is stack-allocated
> during ParNewGeneration::collect(), forcing us to send the tracer as an
> argument to functions that might need it. This patch moves the tracer,
> and makes it a field in ParNewGeneration instead.
>
> The change includes adding a getter for this field, even though it is
> not used, however, future changes adding PLAB tracing [1] will require
> this.
>
> Webrev:
> http://cr.openjdk.java.net/~mlarsson/8066566/webrev.00/

parNewGeneration.hpp
+  ParNewTracer& gc_tracer() {
+    return _gc_tracer;
+  }
+

Can this getter return a const ParNewTracer* instead? I believe most of 
the methods on ParNewTracer should be const.

Thanks,
Erik

> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8066566
>
> Testing:
> jprt
>
> Thanks,
> Marcus
>
> [1]: https://bugs.openjdk.java.net/browse/JDK-8055845


More information about the hotspot-gc-dev mailing list