RFR (S): 8066566: Refactor ParNewGeneration to contain ParNewTracer

Erik Helin erik.helin at oracle.com
Wed Dec 10 16:55:09 UTC 2014


On 2014-12-10, Marcus Larsson wrote:
> Hi again,
> 
> Updated the patch with some cleanups to use 'const ParNewTracer*' rather
> than 'ParNewTracer&' where appropriate.
> 
> Webrev:
> http://cr.openjdk.java.net/~mlarsson/8066566/webrev.02/

Looks good, Reviewed.

Thanks,
Erik

> 
> Incremental:
> http://cr.openjdk.java.net/~mlarsson/8066566/webrev.01-02/
> 
> Thanks,
> Marcus
> 
> On 08/12/14 12:29, Marcus Larsson wrote:
> >Hi Erik,
> >
> >On 06/12/14 10:57, Erik Helin wrote:
> >>Hi Marcus,
> >>
> >>On 2014-12-04 13:05, Marcus Larsson wrote:
> >>>Hi,
> >>>
> >>>I would like reviews for the following small patch.
> >>>
> >>>Like the bug description says, the ParNewTracer is stack-allocated
> >>>during ParNewGeneration::collect(), forcing us to send the tracer as an
> >>>argument to functions that might need it. This patch moves the tracer,
> >>>and makes it a field in ParNewGeneration instead.
> >>>
> >>>The change includes adding a getter for this field, even though it is
> >>>not used, however, future changes adding PLAB tracing [1] will require
> >>>this.
> >>>
> >>>Webrev:
> >>>http://cr.openjdk.java.net/~mlarsson/8066566/webrev.00/
> >>
> >>parNewGeneration.hpp
> >>+  ParNewTracer& gc_tracer() {
> >>+    return _gc_tracer;
> >>+  }
> >>+
> >>
> >>Can this getter return a const ParNewTracer* instead? I believe most of
> >>the methods on ParNewTracer should be const.
> >
> >Done.
> >
> >Incremental:
> >http://cr.openjdk.java.net/~mlarsson/8066566/webrev.00-01/
> >
> >New webrev:
> >http://cr.openjdk.java.net/~mlarsson/8066566/webrev.01/
> >
> >Thanks for looking at this!
> >Marcus
> >
> >>
> >>Thanks,
> >>Erik
> >>
> >>>Bug:
> >>>https://bugs.openjdk.java.net/browse/JDK-8066566
> >>>
> >>>Testing:
> >>>jprt
> >>>
> >>>Thanks,
> >>>Marcus
> >>>
> >>>[1]: https://bugs.openjdk.java.net/browse/JDK-8055845
> >
> 


More information about the hotspot-gc-dev mailing list