RFR: 8067306: Improve STATIC_ASSERT

Kim Barrett kim.barrett at oracle.com
Fri Dec 12 17:12:51 UTC 2014


Thanks for looking at this.

On Dec 12, 2014, at 3:27 AM, Erik Helin <erik.helin at oracle.com> wrote:
> 
> On 2014-12-12, Kim Barrett wrote:
>> Please review this enhancement to the hotspot STATIC_ASSERT() macro.
>> 
>> […]
>> 
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8067306
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8067306/webrev/
> 
> Looks good, thanks for improving this. Do we really need the
> implementation note? The implementation itself is pretty clear to me.

The bit about dependent types isn't entirely obvious and is easy to
forget; I was worried someone might later wonder why it looks more
complicated than seems necessary and "simplify" it.  (I haven't
audited current uses to see if that would immediately fail.)  But I'm
fine with removing it.



More information about the hotspot-gc-dev mailing list