RFR: 8067499: G1SATBCardTableModRefBS should not inherit from CardTableModRefBSForCTRS

Kim Barrett kim.barrett at oracle.com
Wed Dec 17 19:07:04 UTC 2014


Thanks for your review, Bengt.

On Dec 17, 2014, at 7:53 AM, Bengt Rutisson <bengt.rutisson at oracle.com> wrote:
> 
> On 2014-12-17 07:14, Kim Barrett wrote:
>> Please review this change to G1SATBCardTableModRefBS to derive from
>> CardTableModRefBS rather than CardTableModRefBSForCTRS.
>> 
>> […]
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8067499
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8067499/webrev
> 
> Great cleanup!
> 
> One thought about this code in cardTableRS.cpp:
> 
>  41 #if INCLUDE_ALL_GCS
>  42   guarantee(!UseG1GC, "sanity");
>  43 #endif
> 
> I don't think we need the INCLUDE_ALL_GCS guard here since the UseG1GC is always available. Also, I think I would prefer to check for what we actually expect instead of what we don't expect. This is what we are expecting, right?
> 
> guarantee(UseSerialGC | UseConcMarkSweepGC, "santiy”);

Good idea.  I’ll make that change.



More information about the hotspot-gc-dev mailing list