RFR: 8067499: G1SATBCardTableModRefBS should not inherit from CardTableModRefBSForCTRS

Kim Barrett kim.barrett at oracle.com
Wed Dec 17 22:33:42 UTC 2014


On Dec 17, 2014, at 7:53 AM, Bengt Rutisson <bengt.rutisson at oracle.com> wrote:
> 
> One thought about this code in cardTableRS.cpp:
> 
>  41 #if INCLUDE_ALL_GCS
>  42   guarantee(!UseG1GC, "sanity");
>  43 #endif
> 
> I don't think we need the INCLUDE_ALL_GCS guard here since the UseG1GC is always available. Also, I think I would prefer to check for what we actually expect instead of what we don't expect. This is what we are expecting, right?
> 
> guarantee(UseSerialGC | UseConcMarkSweepGC, "santiy”);

Here’s a new webrev with that change.

While I was at it, also updated copyright years on touched files that needed it.

g1SATBCardTableModRefBS.cpp 
g1SATBCardTableModRefBS.hpp 
genCollectedHeap.hpp
genOopClosures.inline.hpp
sharedHeap.hpp


Full webrev:
http://cr.openjdk.java.net/~kbarrett/8067499/webrev.03/

Incremental webrev:
http://cr.openjdk.java.net/~kbarrett/8067499/webrev.03.incr/



More information about the hotspot-gc-dev mailing list